✅ Deploy Preview for cornerstone-3d-docs ready!

Name	Link
🔨 Latest commit	a67ccb7
🔍 Latest deploy log	https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67d19e17e6c2a80008405934
😎 Deploy Preview	https://deploy-preview-1815--cornerstone-3d-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

I don't think we're on the right track here. The adapter should return imageIds, and the example/consumer/ohif should create a single segmentation from those imageIds. We might need to tweak the internal segmentation addition and hydration process to make this work, but it's pretty likely to be okay. For now, let's put the volume one on the back burner - we'll need more optimizations to create sub-volumes for each imageId group, and that's a bit more complicated since we'd need to do it only where they're actually located. So make sure the example work with having one segmentation, the segmentation is consisted of multiple imageIds

I don't think we're on the right track here. The adapter should return imageIds, and the example/consumer/ohif should create a single segmentation from those imageIds. We might need to tweak the internal segmentation addition and hydration process to make this work, but it's pretty likely to be okay. For now, let's put the volume one on the back burner - we'll need more optimizations to create sub-volumes for each imageId group, and that's a bit more complicated since we'd need to do it only where they're actually located. So make sure the example work with having one segmentation, the segmentation is consisted of multiple imageIds

I was really hoping you would point to specific parts of the code and ask for specific changes instead of abstract ones. I'm not following what you're asking me to do.

So basically the idea is to have this work.

const { labelMapImages } = 
        await Cornerstone3D.Segmentation.createFromDICOMSegBuffer(
            referenceImageIds,
            arrayBuffer,
            {
                metadataProvider: metaData,
                skipOverlapping: false
            }
        );

Then we do

csToolsSegmentation.addSegmentations([
        {
            segmentationId,
            representation: {
                type: cornerstoneTools.Enums.SegmentationRepresentations
                    .Labelmap,
                data: {
                    imageIds: labelMapImages.flat()
                }
            }
        }
    ]);

The key files that need to be changed are

https://github.com/cornerstonejs/cornerstone3D/blob/main/packages/tools/src/eventListeners/segmentation/imageChangeEventListener.ts

Here

const derivedImageId = getCurrentLabelmapImageIdForViewport(
        viewportId,
        representation.segmentationId
      );

as you see it only get one labelmapimageId for viewport => but we have changed that so that it can have multiple for one segmentationId (overlapping)

and then later on in that file

viewport.addImages([
        {
          imageId: derivedImageId,
          representationUID: `${segmentationId}-${SegmentationRepresentations.Labelmap}`,
          callback: ({ imageActor }) => {
            imageActor.getMapper().setInputData(imageData);
          },
        },
      ]);

you see we only add one derivedImageId to the viewport (since we only had support for one slice -> one imageId -> per labelmap) but now we want to support multiple

so we need to loop over derivedImageIds for that slice and then add them one by one which should work

Hope this helps

@sedghi is there a timeline for feedback on this? We are blocked by this PR.

I've given my review to pedro, seems like he is on vacation?

@sedghi as asked on slack, here is the table of comparison for the skipOverlapping flag (master vs this branch):